Feat stake OFAC #4203
Feat stake OFAC #4203
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
953.95 KB (🟡 +17 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
One Page Changed Size
The following page changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/swap |
732 B (🟡 +2 B) |
954.67 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Test suite run success1485 tests passing in 203 suites. Report generated by 🧪jest coverage report action from 667b858 |
src/store/ofac.ts
Outdated
| @@ -62,6 +62,7 @@ export const ofacApi = createApi({ | |||
| return { error: { status: 'CUSTOM_ERROR', data: (error as Error).message } } | |||
| } | |||
| }, | |||
| keepUnusedDataFor: 24 * 60 * 60, // 2 | |||
There was a problem hiding this comment.
Outdated comment (should be 1 day?)
There was a problem hiding this comment.
No, I somehow managed to delete the "4 hours" from "24 hours" :D
compojoom
force-pushed
the
feat-stake-ofac
branch
from
e96e7e6
to
cd0e4b8
Compare
Currently once we do the ofac check the data will be discarded after 60s (if no active listeners) and whenever we navigate to a page that needs that data a new call to the rpc is going to be made. With this change the data will be kept for up to 24h (if no active listener).
compojoom
force-pushed
the
feat-stake-ofac
branch
from
cd0e4b8
to
667b858
Compare
What it solves
Checks whether the currently connected wallet or safe is on the OFAC list and blocks access to the stake feature.
How to test it
You can use impersonator.xyz with any of the addresses on the https://github.com/ultrasoundmoney/ofac-ethereum-addresses/blob/main/data.csv list and it should display a block letting you know that the address is blocked.
Screenshots
Checklist